Fix reloading file with axis #2762
Conversation
This fixes following error:
Exception in Tkinter callback
Traceback (most recent call last):
File "/usr/lib/python3.7/tkinter/init.py", line 1705, in call
return self.func(*args)
File "/home/sundtek/devel/linuxcnc/bin/axis", line 2796, in touch_off_system
reload_file(False)
File "/home/sundtek/devel/linuxcnc/bin/axis", line 1911, in reload_file
shutil.copyfile(loaded_file, tempfile)
File "/usr/lib/python3.7/shutil.py", line 104, in copyfile
raise SameFileError("{!r} and {!r} are the same file".format(src, dst))
shutil.SameFileError: '/tmp/tmp3d2pd26j/sidewall.nc' and '/tmp/tmp3d2pd26j/sidewall.nc' are the same file
opening the tmp file will overwrite loaded_file, the patch backups the original loaded_file and sets loaded_file back to the original name after loading the temp file.
The issue here is that if you open a gcode file, and then change the file on disk, you'll think your changes are completely inert because they don't show up in the GUI, but actually LinuxCNC has its own separate file handle behind-the-scenes, and your machine can do scary and unpredictable things. With this fix, the code being executed by LinuxCNC always matches what is displayed in the AXIS GUI even if you subsequently change the file.
|
Have you tested this with a filter file configured? |
|
My patch will basically disable #2418 it's not a solution either, just a temporary workaround (don't pull). @rmu75 mentioned that linuxcnc is reloading the file when starting a job. So "user" open should create a copy of the original file. |
|
I am still around but evidently don't understand enough about what is going on to recognise the problem, it works fine on my system. I also don't see how your patch disables #2418 - it looks like it keeps it intact to me? |
|
I've attached the axis file from my system (as If I recall correctly, I made this by manually applying my patch to the version of axis that was already installed. |
|
I think I explained everything in #2490. Maybe I'm missing something, but behaviour here is constistent with that explanation. First, a temporary filename is constructed from random but fixed temp dir location plus base filename of "loaded_file". So when you reload, loaded_file already points to the temporary file and will try to copy it over itself (and miss any changes to the original file btw). |
|
Oh, I hadn't realised there was a specific reload button. I always reload by reopening the same file, that'll be why I didn't notice anything wrong. |
|
Is this still a live PR? It sounds like it might have been overtaken by events? |
|
I am still confused about whether this bug still exists. (I do think it's a bug, you should need to reload the file to run the modified version, it should be safe to edit the file on disk.) |
|
If you're asking for my view: I'm still just using the version from #2762 (comment) , which has my fix from #2418 (which breaks the reload button, which I never use). But sadly I'm planning to move away from LinuxCNC soon anyway so my view doesn't count for much. |
This fixes following error:
Exception in Tkinter callback
Traceback (most recent call last):
File "/usr/lib/python3.7/tkinter/init.py", line 1705, in call return self.func(*args)
File "/home/sundtek/devel/linuxcnc/bin/axis", line 2796, in touch_off_system reload_file(False)
File "/home/sundtek/devel/linuxcnc/bin/axis", line 1911, in reload_file shutil.copyfile(loaded_file, tempfile)
File "/usr/lib/python3.7/shutil.py", line 104, in copyfile raise SameFileError("{!r} and {!r} are the same file".format(src, dst)) shutil.SameFileError: '/tmp/tmp3d2pd26j/sidewall.nc' and '/tmp/tmp3d2pd26j/sidewall.nc' are the same file
opening the tmp file will overwrite loaded_file, the patch backups the original loaded_file and sets loaded_file back to the original name after loading the temp file.